fix: KMS client plaintext byteOffset (generate too) #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KMS Client *may* return a Buffer that is not isolated. i.e. the byteOffset !== 0. This means that the unencrypted data key is possibly accessible to someone else. If this is the node shared Buffer, then other code within this process _could_ find this secret. Copy Plaintext to an isolated ArrayBuffer and zero the Plaintext.
lizroth
approved these changes
Apr 15, 2019
mattsb42-aws
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The KMS Client may return a Buffer that is not isolated.
i.e. the byteOffset !== 0.
This means that the unencrypted data key is possibly accessible to someone else.
If this is the node shared Buffer, then other code within this process could find this secret.
Copy Plaintext to an isolated ArrayBuffer and zero the Plaintext.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.