Skip to content

chore: update dependancies #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Aug 4, 2020

Dependabot does not play well with lerna and npm.

Also, update a test file to match the typescript version.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Dependabot does not play well with lerna and npm.

Also, update a test file to match the typescript version.
Copy link
Contributor

@alex-chew alex-chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed you also made very similar changes to modules/material-management-browser/src/browser_cryptographic_materials_manager.ts in #394 , are there any other places that need those changes?

@seebees
Copy link
Contributor Author

seebees commented Aug 4, 2020

No @alex-chew the changes in source were easy to catch, but the tests did not fail until the update was pushed. When building the other PR, I should have applied the updates and tested again, just to make sure :(

@seebees seebees merged commit 20045ca into aws:master Aug 4, 2020
@seebees seebees deleted the consolidated-dependencies-update branch August 4, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants