feat: cacheing material management #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add abstract methods in cache-material * Add implementation in caching-materials-manager-node * update material-management to export more granular interface * update serialize with max values and `serializeEncryptedDataKey`
mattsb42-aws
requested changes
Apr 9, 2019
There was a problem hiding this comment.
Either for now or soon, there's a bunch of test vectors for the cache keys here[1].
[1] https://github.com/aws/aws-encryption-sdk-python/blob/master/test/unit/test_caches.py
mattsb42-aws
requested changes
Apr 16, 2019
modules/cache-material/src/get_local_cryptographic_materials_cache.ts
Outdated
Show resolved
Hide resolved
modules/cache-material/src/caching_cryptographic_materials_decorators.ts
Outdated
Show resolved
Hide resolved
mattsb42-aws
previously approved these changes
Apr 17, 2019
|
Please roll this branch back and add the browser implementation in a separate PR. |
mattsb42-aws
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
serializeEncryptedDataKeyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.