aes-keyring-browser #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| wrappingSuite: WrappingSuiteIdentifier | ||
| } | ||
|
|
||
| export class AesKeyringWebCrypto extends KeyringWebCrypto { |
There was a problem hiding this comment.
We need to add notes explaining exactly which AES modes we're using/supporting. The problem is that "AESWrap" or "AESKeyWrap" has a very specific meaning, which I'm almost positive we don't want. I think we only support GCM? If so, I recommend changing the leading "Aes" from all methods/objects to "AesGcm" to make this clear and avoid confusion.
| keyName: string, | ||
| material: WebCryptoEncryptionMaterial, | ||
| aad: Uint8Array, | ||
| wrappingMaterial: WebCryptoDecryptionMaterial |
There was a problem hiding this comment.
Shouldn't this be WebCryptoEncryptionMaterial?
| keyName: string, | ||
| material: WebCryptoDecryptionMaterial, | ||
| wrappingMaterial: WebCryptoDecryptionMaterial, | ||
| edk: EncryptedDataKey, |
There was a problem hiding this comment.
It feels really weird taking in both the material and the edk. Are both actually required?
SalusaSecondus
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.