fix: Update user agent calls to KMS #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to track the user agent used in calls made with this SDK. This is to be able to identify which version of the Encryption SDK is being used to assist in any future debugging requested by customers. This tracking is done in the default `clientProvider`. To opt out of this, you can create your own.
agray256
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to identify which implementation of the AWS Encryption SDK
is being used in order to assist in any requests from customers
or for debugging as necessary by developers.
We plan to utilize the user agent set by the SDK to achieve this.
This identification is done in the default
clientProvider.Users can create their own
clientProvider,and set a different user agent.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: