Skip to content

fix: Zero length frames in old version of Node #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2019
Merged

fix: Zero length frames in old version of Node #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b80ac4e
fix: Zero length frames in old version of Node
seebees Aug 27, 2019
96cf1cd
Merge branch 'master' into empty-frame-old-node
mattsb42-aws Sep 6, 2019
33ffc23
Merge branch 'master' into empty-frame-old-node
seebees Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/decrypt-node/src/decipher_stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ export function getDecipherStream () {
decipherState = {} as any

decipher.setAuthTag(authTag)
/* In Node.js versions 10.9 and older will fail to decrypt if decipher.update is not called.
* https://github.com/nodejs/node/pull/22538 fixes this.
*/
if (!content.length) decipher.update(Buffer.alloc(0))

const clear: Buffer[] = []
for (const cipherChunk of content) {
Expand Down