fix: integration silent errors #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cli’s for the integration packages could silently error. The logic is wrapped in an immediately invoked function expression. The function is async, and if there is an error this results in an unhandled promise rejection. Catch the error, log, and exit with a non-zero code. I also cleaned up some of the path expressions, and removed the ts-ignore.
ragona
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli’s for the integration packages could silently error.
The logic is wrapped in an immediately invoked function expression.
The function is async, and if there is an error
this results in an unhandled promise rejection.
Catch the error, log, and exit with a non-zero code.
I also cleaned up some of the path expressions,
and removed the ts-ignore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: