fix: ENCODED_SIGNER_KEY in encryption context #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CryptographicMaterialsManager can change entries to the encryptionContext but changing these values has consequences. The DefaultCryptographicMaterialsManager uses the value in the encryption context to store public signing key. If the caller is using this value in their encryption context the Default CMM is probably not the CMM they want to use.
mattsb42-aws
requested changes
Aug 22, 2019
modules/material-management-browser/src/browser_cryptographic_materials_manager.ts
Outdated
Show resolved
Hide resolved
modules/material-management-node/src/node_cryptographic_materials_manager.ts
Outdated
Show resolved
Hide resolved
mattsb42-aws
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CryptographicMaterialsManager can change entries to the encryptionContext
but changing these values has consequences.
The DefaultCryptographicMaterialsManager uses the value in the encryption context
to store public signing key.
If the caller is using this value in their encryption context the Default CMM
is probably not the CMM they want to use.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: