Skip to content

chore: Fix credentials.expiration #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Jul 29, 2024

In the SDK credentials.expiration
now needs to be a Date object.

This also removes @aws-sdk/karma-credential-loader

See: aws/aws-sdk-js-v3#5890

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

In the SDK credentials.expiration
now needs to be a `Date` object.

This also removes `@aws-sdk/karma-credential-loader`

See: aws/aws-sdk-js-v3#5890
@seebees seebees requested a review from a team as a code owner July 29, 2024 23:53
@seebees seebees merged commit 89a2b68 into master Jul 30, 2024
8 checks passed
@seebees seebees deleted the seebees/fix-expiration-in-integration-browser branch July 30, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants