Skip to content

add explicit public API definition #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2019
Merged

add explicit public API definition #97

merged 5 commits into from
Oct 9, 2019

Conversation

mattsb42-aws
Copy link
Member

Description of changes:
Adding an explicit definition of our public API to avoid confusion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


The public API that we will maintain within the constraints of our [versioning policy](./VERSIONING.rst)
consists of all public classes in the `com.amazonaws.encryptionsdk` package unless otherwise and specifically documented.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public API that we maintain includes all public classes in the in the com.amazonaws.encryptionsdk package unless otherwise documented. Our versioning policy applies to this public API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: "Our versioning policy applies to all public classes in the com.amazonaws.encryptionsdk
package unless otherwise documented."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not to nitpick: it also applies to public constants, methods, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and protected methods, constants, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second try: Our versioning policy applies to all public and protected classes/methods/fields in the com.amazonaws.encryptionsdk
package unless otherwise documented.

@johnwalker
Copy link
Contributor

johnwalker commented Feb 6, 2019

It might be helpful to include a short statement in the versioning policy, that it only applies to non-internal classes.

@johnwalker johnwalker self-requested a review October 9, 2019 00:12
@mattsb42-aws mattsb42-aws merged commit e836a51 into aws:master Oct 9, 2019
@mattsb42-aws mattsb42-aws deleted the api branch October 9, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants