-
Notifications
You must be signed in to change notification settings - Fork 122
add explicit public API definition #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
The public API that we will maintain within the constraints of our [versioning policy](./VERSIONING.rst) | ||
consists of all public classes in the `com.amazonaws.encryptionsdk` package unless otherwise and specifically documented. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public API that we maintain includes all public classes in the in the com.amazonaws.encryptionsdk
package unless otherwise documented. Our versioning policy applies to this public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: "Our versioning policy applies to all public classes in the com.amazonaws.encryptionsdk
package unless otherwise documented."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, not to nitpick: it also applies to public constants, methods, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and protected methods, constants, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second try: Our versioning policy applies to all public and protected classes/methods/fields in the com.amazonaws.encryptionsdk
package unless otherwise documented.
It might be helpful to include a short statement in the versioning policy, that it only applies to non-internal classes. |
Description of changes:
Adding an explicit definition of our public API to avoid confusion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.