Skip to content

doc: clarify JceMasterKey supported algorithms #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2022
Merged

doc: clarify JceMasterKey supported algorithms #761

merged 2 commits into from
May 12, 2022

Conversation

alex-chew
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@alex-chew alex-chew requested a review from a team as a code owner May 11, 2022 22:55
texastony
texastony previously approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we would have to re-generate the Java Docs for this to be discoverable outside of the source code.

And we should NOT do that with out a release...

@alex-chew alex-chew merged commit 12a1dc9 into master May 12, 2022
@alex-chew alex-chew deleted the clarify-jce-master-key-support branch May 12, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texastony texastony texastony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-chew @texastony