Log a warning when an unsupported asym algorithm is used with JceMasterKey #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdonlan
approved these changes
Jul 20, 2018
lizroth
approved these changes
Jul 20, 2018
| @@ -234,12 +237,17 @@ public WrappingData(final Cipher cipher, final byte[] extraInfo) { | |||
| } | |||
|
|
|||
| private static class Rsa extends JceMasterKey { | |||
| private static final Pattern SUPPORTED_TRANSFORMATIONS = | |||
There was a problem hiding this comment.
It might be nice to have some kind of test coverage for this in general in the future to make sure we warn / don't warn as intended
josecorella
pushed a commit
that referenced
this pull request
Nov 20, 2023
josecorella
pushed a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #56
I have manually verified that all existing tests pass as well as manual verification that a logged warning appears if and only if an unsupported algorithm is used with
JceMasterKey.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.