chore(JavaDocs): detail thread saftey of SDK Client Builders #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The AWS SDK for Java's Service Client builders are not thread safe.
Crypto Tools customer's have reported odd,
occasionally disruptive behavior when using them
in a concurrent setting.
As such,
Crypto Tools should make it clear how to set a KMS Client
in a thread safe manner.
Which can be done via the Regional Client Supplier.
Additionally,
we can improve on the Java Documentation to highlight that
Builders are not thread safe,
and that proper Builder suppliers MUST be used,
or customers SHOULD use the alternative client configuration methods.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: