test: Run ESDK .NET v4.0.1 Test Vectors in CI #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabhichow
changed the title
imabhichow
changed the title
imabhichow
force-pushed
the
imabhichow/vector-tests
branch
from
aaad59b to
1e5ee36
Compare
josecorella
requested changes
Mar 11, 2024
texastony
reviewed
Mar 11, 2024
There was a problem hiding this comment.
I am having a hard relating this to the Private PR that I thought did the same thing:
https://github.com/aws/private-aws-encryption-sdk-java-staging/pull/68/files#diff-e390fc0ad5f952462bfc117b51fd807859eac77e5f85a206b90747b3218c679f
Some common lines are here, but there are significant differences.
It has been a while since I looked at this code base...
I think we may need to go over this in more detail.
Co-authored-by: Tony Knapp <[email protected]>
texastony
reviewed
Mar 12, 2024
josecorella
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
-Dmasterkey=true) and Keyrings.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: