Throw a more useful exception when trying to use the RawRsaKeyring to encrypt without a public key #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… encrypt without a public key
mattsb42-aws
previously approved these changes
Apr 23, 2020
mattsb42-aws
approved these changes
Apr 23, 2020
WesleyRosenblum
added a commit
that referenced
this pull request
Apr 23, 2020
… encrypt without a public key (#180) * Throw a more useful exception when trying to use the RawRsaKeyring to encrypt without a public key * Add a test for trying to decrypt without a private key
WesleyRosenblum
added a commit
that referenced
this pull request
Apr 24, 2020
…he AWS KMS keyring (#178) * Add an example for replicating the behavior of the AWS KMS MKP * Rewording based on feedback * Updating based on python example updates * Matching python wording * Throw a more useful exception when trying to use the RawRsaKeyring to encrypt without a public key (#180) * Throw a more useful exception when trying to use the RawRsaKeyring to encrypt without a public key * Add a test for trying to decrypt without a private key * Update src/examples/java/com/amazonaws/crypto/examples/keyring/awskms/ActLikeAwsKmsMasterKeyProvider.java Co-Authored-By: Matt Bullock <[email protected]> Co-authored-by: Matt Bullock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently we rely on the JCE Cipher class to throw an exception when a user tries to encrypt with the RawRsaKeyring but has not configured a public key. The exception message does not obviously indicate what is wrong, so this change will explicitly check for a missing public key before attempting encryption and throw a more useful exception.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: