-
Notifications
You must be signed in to change notification settings - Fork 122
Adding a validate version error handling as discussed in issue #113 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9fabd6d
Adding a validate version error handling as discussed in issue #113
josecorella 63feeda
Issue #113. Error handling version number.
josecorella 3e3da82
Added an IDE artifact to the .gitignore
josecorella a479e24
Added an IDE artifact to the .gitignore
josecorella 411d0c8
Added the correct version of the CipherTeext as part of the error.
josecorella e2bbc3b
Changed the value for the appropriate version number. Using Current_C…
josecorella afec681
Added a test for the Invalid Version Type.
josecorella 531a871
Cleaning up the code in the parseVersion function.
josecorella 2031e39
Cleaned up CiphertextHeaders
josecorella 444146a
There was a bug in the parseVersion code. Before it was converting th…
josecorella 0a4653e
There was a bug with the test I wrote. With the conditions that I pas…
josecorella da3f6de
Fixed typo in error message.
josecorella 8be7db8
Modified my test in the invalidVersion Test. Before it would overwrit…
josecorella 5b0dfec
Merge branch 'master' into cipherTextHeader
lizroth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,4 @@ target/ | |
.classpath | ||
/bin/ | ||
.idea/ | ||
*.iml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our style requires a space between the
if
and before the(
.