Backwards compatibility issue with alias/name and getMasterkey

[michaelajr]

In 1.3.1 I could get a MasterKeyProvider using aliases and regions. In the code below I have a list of regions (this.regions) where the alias (this.keyId) has been created in each. I create the KmsMasterKeyProvider for each region and return a MultiProvider.

    private MasterKeyProvider<?> masterKeyProvider() {

        AWSCredentialsProvider credentials
                = new DefaultAWSCredentialsProviderChain();

        List<KmsMasterKey> masterKeys
                = new LinkedList<>();

        for (String region : this.regions) {

            KmsMasterKeyProvider provider
                    = new KmsMasterKeyProvider(
                            credentials,
                            Region.getRegion(
                                    Regions.fromName(
                                            region)),
                            new ClientConfiguration(),
                            this.keyId);

            masterKeys.add(
                    provider.getMasterKey(
                            this.keyId));
        }

        return MultipleProviderFactory
                .buildMultiProvider(
                        masterKeys);
    }

I can then use the MultiProvider with AwsCrypto like so...

                CryptoOutputStream<?> encryptingStream
                        = awsCrypto
                                .createEncryptingStream(
                                        masterKeyProvider(),
                                        fileOutputStram))

This no longer works. The getMasteKeyMethod at line 452 of the KmsMasterKeyProvider.java now requires an ARN for the keyId.

String regionName = parseRegionfromKeyArn(keyId);

The result is that regionName is null.

Is there another way to do what I'm trying to do? Thanks.

M

[michaelajr]

So creating the full ARN from the alias seems to be the new way of doing this.

    private MasterKeyProvider<?> masterKeyProvider() {

        final AWSCredentialsProvider credentials
                = new DefaultAWSCredentialsProviderChain();

        List<KmsMasterKeyProvider> providers 
                = new LinkedList<>();

        for (String region : this.regions) { 
            providers.add(
                    KmsMasterKeyProvider
                            .builder()
                            .withCredentials(
                                    credentials)
                            .withKeysForEncryption(
                                    new StringBuilder()
                                            .append("arn:aws:kms:")
                                            .append(region)
                                            .append(":")
                                            .append(this.account)
                                            .append(":")
                                            .append(this.keyId)
                                            .toString())
                            .build());
        } 

        return MultipleProviderFactory
                .buildMultiProvider(
                        providers);
    }

[bdonlan]

This is a regression. Reopening to fix.

[bdonlan]

Note that when using the builder it is intentional that you need to specify a default region, but that also is currently broken. When using legacy constructors we intended for behavior to be unchanged.