chore(deps): Update pytest version in upstream-requirements-py311.txt #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a deprecation warning
alex
changed the title
texastony
previously approved these changes
May 12, 2024
texastony
reviewed
May 14, 2024
| @@ -22,13 +22,12 @@ | |||
|
|
|||
|
|
|||
| class TestWarnDeprecatedPython: | |||
| def test_happy_version(self): | |||
| def test_happy_version(self, recwarn): | |||
There was a problem hiding this comment.
Question: Sorry, I do not follow.
Why is this argument necessary?
Is this some magic incantation to tell pytest to record warnings?
And then assert that none were recorded?
There was a problem hiding this comment.
Yes, these are called fixtures in pytest, see https://docs.pytest.org/en/8.2.x/how-to/capture-warnings.html#recwarn
This change was necessary because pytest.warns(None) is not allowed anymore.
|
This PR's CI is blocked on fixing the Mac OS CI.
|
texastony
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.