Skip to content

for tox resetdocs, make sure that the directory exists to avoid potential side effects of using rm -f #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018

Conversation

mattsb42-aws
Copy link
Member

Description of changes:

In the vein of "test more permutations before committing", the thing that the rm -f was solving in resetdocs was the case where the generated docs directory did not already exist. I am still of the mind that we should not clobber files in the rm step, so this change makes the generated directory if it does not already exist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattsb42-aws mattsb42-aws requested a review from a team May 8, 2018 00:12
@lizroth lizroth merged commit 4482bf4 into aws:master May 18, 2018
@mattsb42-aws mattsb42-aws deleted the rm-fix branch May 19, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants