Skip to content

Finish fixing manifest #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2018
Merged

Finish fixing manifest #63

merged 5 commits into from
May 3, 2018

Conversation

mattsb42-aws
Copy link
Member

Description of changes:

I have verified that this works locally, first creating the source build, then extracting the source build tarball and running the local test suite.

If anyone has suggestions on how to set this up as a tox environment, I'm open to ideas. If not, I'll keep thinking on that and keep moving.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General approval, per discussion, suggestion to add a note to the file about intended audience since it is fairly limited

@@ -0,0 +1,23 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a note for users that this is intended to verify MANIFEST.in and is not of much interest to end users?

@mattsb42-aws mattsb42-aws merged commit f4a9d37 into aws:master May 3, 2018
@mattsb42-aws mattsb42-aws deleted the finish-fixing-manifest branch May 3, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants