Skip to content

chore: Adds python36 deprecation to changelog #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

ShubhamChaturvedi7
Copy link
Contributor

Issue #, if available:

Description of changes:

chore: Adds python36 deprecation to changelog

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@ShubhamChaturvedi7 ShubhamChaturvedi7 requested a review from a team as a code owner December 19, 2022 10:56
@ShubhamChaturvedi7 ShubhamChaturvedi7 changed the title chore: Adds pyhton36 deprecation to changelog chore: Adds python36 deprecation to changelog Dec 21, 2022
CHANGELOG.rst Outdated
Comment on lines 12 to 14
Python 3.6 can still use the 2.x line of the AWS DynamoDB Encryption Client for Python,
which will continue to receive security updates, in accordance
with our `Support Policy <https://github.com/aws/aws-dynamodb-encryption-python/blob/master/SUPPORT_POLICY.rst>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true?
Doesn't #481 make that not true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded this based on the fact that we are dropping support for 2.x as well.

seebees
seebees previously approved these changes Jan 10, 2023
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit f360734 into aws:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants