Skip to content

chore: Upgrade hypothesis #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2022
Merged

chore: Upgrade hypothesis #442

merged 3 commits into from
Nov 14, 2022

Conversation

lavaleri
Copy link
Contributor

@lavaleri lavaleri commented Nov 10, 2022

Build is failing due to an un-pinned dependency removing a deprecated method that the current version of hypothesis depends on (but in a way such that tox doesn't just resolve to an earlier version of importlib). This PR upgrades hypothesis so that this should no longer be an issue.

Additionally, the fixed verison of hypothesis adds an additional health check that we need to suppress. It is warning that function fixtures are only called once when used with hypothesis.given, which is usually unexpected. In our case, this is the desired behavior, as the fixture creates a DDB table, and we want to reuse this DDB table across the inputs from hypothesis.given.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lavaleri lavaleri requested a review from a team as a code owner November 10, 2022 22:55
@lavaleri lavaleri changed the title chore:Pin importlib-metadata to version before 5.0 chore:Upgrade Hypothesis Nov 10, 2022
@lavaleri lavaleri changed the title chore:Upgrade Hypothesis chore: Upgrade hypothesis Nov 10, 2022
@lavaleri lavaleri merged commit c8a4796 into aws:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants