chore: Fix release validation #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2021
texastony
approved these changes
Nov 12, 2021
|
Overriding failing docs test; it's hitting the (broken) public docs, which won't be updated until this fix is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes discovered during the most recent release.
Also fix the doc generation. When we pulled in the newest version of sphinx it changed how the configuration works, specifically the
autodoc_default_flagsparameter we were using is now deprecated. See docsTo see the effect, compare the good stable docs to the empty latest docs
Testing:
CI is failing the broken link check on the docs because it always hits the public docs (which don't yet incorporate this fix). I've confirmed locally (
tox -e serve-docs) that we're back to generating the full docs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.