chore: Remove support for python 2 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farleyb-amazon
force-pushed
the
py2-deprecation
branch
from
78cab04 to
cfb1257
Compare
texastony
previously approved these changes
Jul 15, 2021
texastony
previously approved these changes
Jul 15, 2021
|
Glad you caught that. Have you run a generic grep for py2? |
texastony
reviewed
Jul 15, 2021
Yup, that's right. "If our python version is less than 3.4, we depend on enum34". Looks like the enum34 package is a backporting of a new feature introduced in Python 3.4 into older versions of Python, which means we do not need it. Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.