chore: fix all CI and start migration to GitHub Actions #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove 3.4 - add 3.8
- fixes issues with multiple service mocks in Python 2 - module scope avoids resetting the mocked service for tests that use multiple mocked tables
…g fast tests for Python 2
- The ls command was getting a relative path when the script ran but a bare filename in manual checks.
mattsb42-aws
changed the title
mattsb42-aws
requested review from
farleyb-amazon and
MatthewBennington
and removed request for
robin-aws
This was referenced Aug 25, 2020
farleyb-amazon
approved these changes
Aug 26, 2020
| Tag.NULL.tag: _deserialize_null, | ||
| Tag.LIST.tag: _deserialize_list, | ||
| Tag.MAP.tag: _deserialize_map, | ||
| Tag.BINARY.tag: _deserialize_binary, # pylint: disable=no-member |
There was a problem hiding this comment.
Should we just disable this check globally?
There was a problem hiding this comment.
No, it's a good check to have, it just seems to get confused with the way that we're constructing enums with custom attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
aws/crypto-tools#21
fixes: #67
Description of changes:
This cleans up a lot of issues that were breaking CI and starts the migration of non-integ CI to GitHub Actions.
GitHub Actions workflows:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: