Fix upstream tests #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mattsb42-aws merged 2 commits into aws:master from mattsb42-aws:fixit

Sep 3, 2019

Member

mattsb42-aws commented Sep 3, 2019 •

edited

Loading

Issue #, if available: #122 pyca/cryptography#4979

Description of changes:

Fixes upstream test environments to correctly block all environment variables.
Fixes integration test parameterization logic to fail at execution time rather than test collection time.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

mattsb42-aws added 2 commits

September 3, 2019 12:42


          do not pass through any environment variables in the upstream tests

0503e5c


          change AWS KMS CMP parameterization from emiting a CMP to emitting a …

c2fd39d

…callable that returns a CMP to address #122

ttjsu-aws approved these changes

View reviewed changes

mattsb42-aws merged commit 45f3826 into aws:master

mattsb42-aws deleted the fixit branch

September 3, 2019 21:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet