Skip to content

Remove explicit "hypothesis" pytest markers #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattsb42-aws opened this issue Jun 27, 2018 · 3 comments
Closed

Remove explicit "hypothesis" pytest markers #76

mattsb42-aws opened this issue Jun 27, 2018 · 3 comments

Comments

@mattsb42-aws
Copy link
Member

Starting to test this, it looks like this error first appears in 3.64.0

https://travis-ci.org/awslabs/base64io-python/builds/397145142

@mattsb42-aws
Copy link
Member Author

@mattsb42-aws
Copy link
Member Author

Per guidance from hypothesis, it looks like the root cause of this is that we add a "hypothesis" pytest marker to tests that use hypothesis, but hypothesis already adds this marker (currently undocumented). Hypothesis is following up with pytest about the issue with the same marker being applied multiple times, but our action here is just to remove our explicit "hypothesis" markers.

@mattsb42-aws
Copy link
Member Author

Looks like pytest fixed the underlying issue with re-applying markers. We should still remove the hypothesis markers though, to avoid breaking on previous pytest versions.

@mattsb42-aws mattsb42-aws changed the title Hypothesis 3.64.0 is breaking tests Remove explicit "hypothesis" pytest markers Jul 23, 2018
@mattsb42-aws mattsb42-aws removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants