Add ExtraDataSupplier to Metastore, and support for overriding KMS requests in DirectKMSMaterialProvider #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves duplicated code into a common method in the MetaStore.
There isn't any change in behavior here. Just style fixes.
Add the internal tests for ExtraDataSupplier in MetaStore
Fixes an expected exception test for testng.
|
Failed check from Travis is expected because JDK11 recently stopped working. |
SalusaSecondus
approved these changes
Jan 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed check from Travis is expected because JDK11 recently stopped working on Travis (nothing to do with our code).
This is a near direct copy of DirectKMS and MetaStore. Commit 4e682ea is a direct copy of the internal metastore and DirectKMSMaterialProvider. There will probably need to be a minor update to this to get it to work with testng.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.