Whitespace and import cleanup on tests #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feeds the tests through intellij's code cleanup. It reorders imports and fixes whitespace.
|
Are there instructions so other people can do this? I don't want a battle of formatters. |
SalusaSecondus
approved these changes
Jan 7, 2019
|
It seems that we've agreed not to use * imports. The absence of instructions around whitespace and style is something that we'll fix soon, hopefully through checkstyle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feed code through intellij's formatter for fixing whitespace and reordering imports.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.