-
Notifications
You must be signed in to change notification settings - Fork 15
feat: index support for beacons #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmcdonald3
approved these changes
Mar 27, 2023
if DDB.IsValid_NonKeyAttributeNameList(newAttributes) then | ||
Success(projection.(NonKeyAttributes := Some(newAttributes))) | ||
else | ||
Failure("Project had invalid attribute name list") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Failure("Project had invalid attribute name list") | |
Failure("Projection had invalid attribute name list") |
seebees
added a commit
that referenced
this pull request
Mar 27, 2023
* feat: index support for beacons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
With searchable encryption, indexes need certain transformations -- index on the beacon (aws_dbe_b_foo) rather than the actual encrypted field (foo), and add fields to any Projection so we can search on the beacon, and then properly filter on the unencrypted attributes.
This implies modifying the input to CreateTabe and UpdateTable, as well as the output of DescribeTable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.