-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add more attributes to encryption context #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: support SignAndIncludeInEncryptionContext in enhanced client
* feat: better support of single table design
seebees
reviewed
Mar 18, 2024
...ny/StructuredEncryption/src/AwsCryptographyDbEncryptionSdkStructuredEncryptionOperations.dfy
Show resolved
Hide resolved
seebees
reviewed
Mar 18, 2024
...ny/StructuredEncryption/src/AwsCryptographyDbEncryptionSdkStructuredEncryptionOperations.dfy
Show resolved
Hide resolved
seebees
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just deny this option.
Then I'm good (both encrypt/decrypt)
seebees
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes in specification/changes/2024-02-29-encryption-context/change.md, which are more exactly described in the specification changes.
All the interesting changes are in AwsCryptographyDbEncryptionSdkDynamoDbItemEncryptorOperations.dfy and
AwsCryptographyDbEncryptionSdkStructuredEncryptionOperations.dfy
The changes in the "Util.dfy" files are primarily moved from other places, as a bunch of functionality had to be moved to lower levels of the hierarchy.
All the other changes are from re-running smithy-dafny.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.