Skip to content

chore: Add CI to block on TODOs #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 11, 2024
Merged

chore: Add CI to block on TODOs #713

merged 8 commits into from
Jan 11, 2024

Conversation

lavaleri
Copy link
Contributor

@lavaleri lavaleri commented Jan 10, 2024

Block on TODOs in code, unless they are followed by something like https://github.com/aws/aws-database-encryption-sdk-dynamodb/issues/555 or CrypTool-555. The regex isn't very strict here, but doesn't need to be.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lavaleri lavaleri requested a review from a team as a code owner January 10, 2024 00:49
@lavaleri lavaleri force-pushed the todos-ci branch 3 times, most recently from 91d8d65 to 56d18c2 Compare January 10, 2024 18:34
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajewellamz ajewellamz merged commit 0a45aee into main Jan 11, 2024
@ajewellamz ajewellamz deleted the todos-ci branch January 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants