feat: smithy for virtual fields #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
reviewed
Mar 24, 2023
Comment on lines
227
to
232
| structure VirtualTransform { | ||
| @required | ||
| transform : Transform, | ||
| numbers : NumberList, | ||
| strings : StringList, | ||
| } |
There was a problem hiding this comment.
The other way to model this would be via a union:
union Transform {
upper: Upper(),
lower: Lower(),
insert: Insert(string str),
prefix: Prefix(int len),
suffix: Suffix(int len),
substring: Substring(int start, int end),
...
}
I think this is the more "correct" way to model this, as we can exactly express the inputs to each transform.
There was a problem hiding this comment.
I agree completely.
lavaleri
approved these changes
Mar 27, 2023
seebees
pushed a commit
that referenced
this pull request
Mar 27, 2023
* feat: smithy for virtual fields * use union for Transform * zero-based plus GetSegments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.