feat: add virtual fields #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
approved these changes
Mar 22, 2023
| It can be important to know if a virtual field has a certain quality, | ||
| defined as any of its parts having the quality. | ||
|
|
||
| Examiner MUST be a a callback function that takes a Terminal Location and returns a boolean. |
There was a problem hiding this comment.
Suggested change
| Examiner MUST be a a callback function that takes a Terminal Location and returns a boolean. | |
| Examiner MUST be a callback function that takes a Terminal Location and returns a boolean. |
|
|
||
| ### Limitations | ||
|
|
||
| It is an error to write an field with the same name as a |
There was a problem hiding this comment.
Suggested change
| It is an error to write an field with the same name as a | |
| It is an error to write a field with the same name as a |
|
|
||
| If you write an item with a given field, and later define a virtual field | ||
| with that same name, then future searches will search only on the virtual field, | ||
| and you will not be able to find the item base on the original field value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
add virtual fields
convert between Beacon config and actual beacon objects.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.