chore: Always test/build with locally built MPL and add release safeg… #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
reviewed
Sep 19, 2023
josecorella
approved these changes
Sep 19, 2023
| @@ -0,0 +1,4 @@ | |||
| projectJavaVersion=3.1.0 | |||
There was a problem hiding this comment.
nit: should this be dbesdkJavaVersion instead?
There was a problem hiding this comment.
ah, I was thinking that it would be more obvious that this meant "this project". I.e. if the MPL implemented a similar thing, it would use projectJavaVersion to mean what Java version of the MPL we're on.
texastony
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uards
Updates CI to build/test using local MPL, making it easier to reason about local development, and unblock development with pre-release MPL features.
We already ensure in our release process that we test the examples and test vectors against MPL in maven local, but this PR adds an additional script to ensure there is consistency between the MPL submodule and the MPL version in our build.gradle that can be used before and during a release. It isn't checked in CI, in order to support development against pre-release MPL.
Updated the build.gradle to use the same versions of MPL/Dafnyruntime/etc. across the DB-ESDK, examples, and test vectors. These versions are currently defined in a top level
propertiesfile, that each individual gradle project reads from. This is Java specific for now, to give us the best bang for our buck today.Once effect of this is that I think these dependencies will no longer be caught by dependabot. This is probably ok, as we want to be mindful when upgrading these dependencies anyway.
Tested the Codebuild script update on commits 94fc4b4, 79926a4, and e219262 to ensure expected success/failures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.