Skip to content

chore: update Github alias #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2024
Merged

chore: update Github alias #1471

merged 4 commits into from
Nov 4, 2024

Conversation

kessplas
Copy link
Contributor

@kessplas kessplas commented Nov 1, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kessplas kessplas requested a review from a team as a code owner November 1, 2024 18:04
Copy link

github-actions bot commented Nov 1, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Nov 1, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

lucasmcdonald3
lucasmcdonald3 previously approved these changes Nov 1, 2024
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it'd be cool if we also added Ritvik

@@ -14,7 +14,7 @@ jobs:
env:
# unfortunately we can't check if the approver is part of the CODEOWNERS. This is a subset of aws/aws-crypto-tools-team
# to add more allowlisted approvers just modify this env variable
maintainers: seebees, texastony, ShubhamChaturvedi7, lucasmcdonald3, josecorella, imabhichow, rishav-karanjit, antonf-amzn, justplaz, ajewellamz
maintainers: seebees, texastony, ShubhamChaturvedi7, lucasmcdonald3, josecorella, imabhichow, rishav-karanjit, antonf-amzn, kessplas, ajewellamz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add Ritvik?

Copy link

github-actions bot commented Nov 1, 2024

@kessplas and @lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link

github-actions bot commented Nov 1, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Nov 1, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Nov 1, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Nov 1, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Nov 1, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Nov 1, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Nov 4, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Nov 4, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@kessplas kessplas merged commit dc6ca47 into main Nov 4, 2024
34 of 35 checks passed
@kessplas kessplas deleted the update-names branch November 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants