You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the links about feature flags in the contribution guide under "Feature Flags" section because these is missing link.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
with the name of the context key that enables this new feature (for
1100
1100
example, `ENABLE_STACK_NAME_DUPLICATES`). The context key should be in the
1101
1101
form `module.Type:feature` (e.g. `@aws-cdk/core:enableStackNameDuplicates`).
@@ -1106,12 +1106,12 @@ Adding a new flag looks as follows:
1106
1106
2. Use `FeatureFlags.of(construct).isEnabled(cxapi.ENABLE_XXX)` to check if this feature is enabled
1107
1107
in your code. If it is not defined, revert to the legacy behavior.
1108
1108
3. Add your feature flag to the `FLAGS` map in
1109
-
[cx-api/lib/features.ts](https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cx-api/lib/features.ts). In
1109
+
[cx-api/lib/features.ts](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/lib/features.ts). In
1110
1110
your description, be sure to cover the following:
1111
1111
- Consciously pick the type of feature flag. Can the flag be removed in a future major version, or not?
1112
1112
- Motivate why the feature flag exists. What is the change to existing infrastructure and why is it not safe?
1113
1113
- In case of a "default change flag", describe what the user needs to do to restore the old behavior.
1114
-
4. Add an entry for your feature flag in the [README](https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cx-api/README.md) file.
1114
+
4. Add an entry for your feature flag in the [README](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/README.md) file.
1115
1115
5. In your tests, ensure that you test your feature with and without the feature flag enabled. You can do this by passing the feature flag to the `context` property when instantiating an `App`.
0 commit comments