Skip to content

Fb fix cosmetics, pipeline output directory, manual approval #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

firdousi-begum
Copy link

Issue #, if available:

Description of changes:

  • Cosmetic changes in the description
  • Updated the output S3 directory for pipelines to make it more readable and in one place
  • Added information about Manual model approval

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

absynthe and others added 30 commits October 19, 2022 13:35
Change model_evaluation to latest tensorflow version to avoid error.
… as the endpoint requires that for inference.
refactor: Reduce s3 copy output
Updates to the 05_deployment
Cleaning pipeline + HPO on training
absynthe and others added 17 commits November 3, 2022 17:52
bugfix on evaluation for training_pipeline
Update training pipeline to fix FrameworkProcessor bug from sagemaker.processing
commit e6684e2
Merge: 9f0b787 5f17132
Author: Anamaria Todor <[email protected]>
Date:   Mon Nov 7 08:52:54 2022 +0100

    Merge pull request #12 from absynthe/refactor/04pipelines

    refactor: unused vars, language and import changes

commit 9f0b787
Merge: 75985c7 388b6b6
Author: Anamaria Todor <[email protected]>
Date:   Mon Nov 7 08:52:33 2022 +0100

    Merge pull request #11 from absynthe/fix/connect-02-03

    Fix: connect 02 and 03

commit 5f17132
Merge: ada1a8a 8bac4c3
Author: niklas-palm <[email protected]>
Date:   Sun Nov 6 21:58:22 2022 +0100

    Merge pull request #13 from absynthe/refactor/update-model-fetching

    refactor: Update model fetching

commit 8bac4c3
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 20:57:29 2022 +0000

    Remove output

commit 6aac58d
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 20:54:02 2022 +0000

    Fetch model from known prefix

commit ada1a8a
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 20:36:35 2022 +0000

    Remove cleanup step

commit f559fab
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 20:34:43 2022 +0000

    Remove unsed processor and fetch JsonGet from functions package

commit 8567136
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 20:30:11 2022 +0000

    Remove model approval status

commit a31a0f7
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 19:31:12 2022 +0000

    Remove approaval status parameter

commit 388b6b6
Author: Niklas Palm <[email protected]>
Date:   Sun Nov 6 19:18:18 2022 +0000

    Lower number of max training jobs

commit b4aba82
Merge: f14b6c7 75985c7
Author: Niklas Palm <[email protected]>
Date:   Fri Nov 4 13:46:11 2022 +0000

    Merge branch 'main' into fix/connect-02-03

commit f14b6c7
Author: Niklas Palm <[email protected]>
Date:   Fri Nov 4 13:45:07 2022 +0000

    Connect hpo and evaluation
@corbuno
Copy link

corbuno commented Nov 8, 2022

  • hard to compare here when folders' names are modified
  • one question: have to cleaned up the outputs in all notebooks. In main, the preprocessing notebook has outputs for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants