-
Notifications
You must be signed in to change notification settings - Fork 228
feat: adding Kotlin examples for Working with Items #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to review this code. Can you please match the read operations with the ids that you wrote? instead of using YourPrimaryKeyValue
can you use the 1234
and 1235
examples you wrote in the operations? I started commenting on the individuals but I realized it was the same across the examples.
val tableName = "YourTableName" | ||
val keys = | ||
listOf( | ||
mapOf("PrimaryKey" to AttributeValue.S("YourPrimaryKeyValue1")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is nice if you match the PrimaryKeyValue1
and PrimaryKeyValue2
to the examples 1234
and 1235
that you created with the Write operations, just for uniformity.
For a new user it will also help on the understanding.
|
||
suspend fun main() { | ||
val tableName = "YourTableName" | ||
val key = mapOf("PrimaryKey" to AttributeValue.S("YourPrimaryKeyValue")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment than the BatchGetItem.kt
file, please match with the ids that are written.
@tebanieo Apologies that this took forever (had a kid in the meantime :-) ). I made the changes you requested |
#153