-
Notifications
You must be signed in to change notification settings - Fork 252
#90 check notebook and terminal sessions #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
takeru1205
wants to merge
12
commits into
aws-samples:master
Choose a base branch
from
takeru1205:feature/90_check_notebook_terminal_sessions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#90 check notebook and terminal sessions #114
takeru1205
wants to merge
12
commits into
aws-samples:master
from
takeru1205:feature/90_check_notebook_terminal_sessions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for raising this PR! Could you test this again please since it has been some time since this was originally raised? |
We experienced an issue with the current version of autostop.py recently and replaced our lifecycle config to use this version. Looks like it works as intended, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue: #90
Description of changes:
The current sample lifecycle configuration only checks for notebook sessions. I have updated it to also monitor terminal sessions. This enhancement is vital as the instance will not stop if there are any non-idle notebook sessions.
Testing Done
Idle time is set to 10 minutes.
Logs showing kernel activity:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.