-
Notifications
You must be signed in to change notification settings - Fork 154
feat(all): nodejs16x support #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5b81ad0
feat: added node16 to e2e test
dreamorosi 37e594a
Added runtime to e2eUtils
dreamorosi 451a3f8
feat: added node16 to e2e test
dreamorosi a8a0a4c
chore: added runtime key
dreamorosi 03f4f7c
chore: update occurrences of nodejs14x
dreamorosi 1c2038c
test sam version
dreamorosi af84776
test sam version
dreamorosi 7420b86
revert
dreamorosi 0547533
sam
dreamorosi f4c4246
sam
dreamorosi 822f839
sam
dreamorosi 8c2e436
sam
dreamorosi 26d8824
chore: added .nvmrc
dreamorosi e0c2753
chore: updated cdk example runtime
dreamorosi 336778c
Update packages/metrics/tests/e2e/basicFeatures.decorators.test.ts
dreamorosi 0201fe3
merge conflicts
dreamorosi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,10 @@ jobs: | |
######################### | ||
# Release new version | ||
######################### | ||
- name: "Use NodeJS 14" | ||
- name: "Use NodeJS 16" | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: '14' | ||
node-version: '16' | ||
- name: Install [email protected] | ||
run: npm i -g npm@next-8 | ||
- name: "Setup npm" | ||
|
@@ -39,6 +39,11 @@ jobs: | |
# the dependencies in a separate step | ||
working-directory: ./examples/cdk | ||
run: npm ci | ||
- name: "Setup SAM" | ||
# We use an ad-hoc action so we can specify the SAM CLI version | ||
uses: aws-actions/setup-sam@v2 | ||
with: | ||
version: 1.49.0 | ||
- name: Install SAM example packages | ||
# Since we are not managing the SAM examples with npm workspaces we install | ||
# the dependencies in a separate step | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,10 @@ jobs: | |
######################### | ||
# Release new version | ||
######################### | ||
- name: "Use NodeJS 14" | ||
- name: "Use NodeJS 16" | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: '14' | ||
node-version: '16' | ||
- name: Install [email protected] | ||
run: npm i -g npm@next-8 | ||
- name: "Setup npm" | ||
|
@@ -39,6 +39,11 @@ jobs: | |
# the dependencies in a separate step | ||
working-directory: ./examples/cdk | ||
run: npm ci | ||
- name: "Setup SAM" | ||
# We use an ad-hoc action so we can specify the SAM CLI version | ||
uses: aws-actions/setup-sam@v2 | ||
with: | ||
version: 1.49.0 | ||
- name: Install SAM example packages | ||
# Since we are not managing the SAM examples with npm workspaces we install | ||
# the dependencies in a separate step | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,10 @@ jobs: | |
NODE_ENV: dev | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Node | ||
- name: "Use NodeJS 16" | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: '14' | ||
node-version: '16' | ||
- name: Install [email protected] | ||
run: npm i -g npm@next-8 | ||
- name: "Setup npm" | ||
|
@@ -27,11 +27,18 @@ jobs: | |
# the dependencies in a separate step | ||
working-directory: ./examples/cdk | ||
run: npm ci | ||
- name: "Setup SAM" | ||
# We use an ad-hoc action so we can specify the SAM CLI version | ||
uses: aws-actions/setup-sam@v2 | ||
with: | ||
version: 1.49.0 | ||
- name: Install SAM example packages | ||
# Since we are not managing the SAM examples with npm workspaces we install | ||
# the dependencies in a separate step | ||
working-directory: ./examples/sam | ||
run: npm ci | ||
run: | | ||
sam --version | ||
npm ci | ||
- name: Run lint | ||
run: npm run lerna-lint | ||
- name: Run tests | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,11 +9,10 @@ jobs: | |
steps: | ||
- name: "Checkout" | ||
uses: actions/checkout@v3 | ||
- name: "Use NodeJS 14" | ||
- name: "Use NodeJS 16" | ||
uses: actions/setup-node@v3 | ||
with: | ||
# Always use version 14 as we use TypeScript target es2020 | ||
node-version: 14 | ||
node-version: 16 | ||
- name: "Install [email protected]" | ||
run: npm i -g npm@next-8 | ||
- name: "Install monorepo packages" | ||
|
@@ -25,6 +24,11 @@ jobs: | |
# the dependencies in a separate step | ||
working-directory: ./examples/cdk | ||
run: npm ci | ||
- name: "Setup SAM" | ||
# We use an ad-hoc action so we can specify the SAM CLI version | ||
uses: aws-actions/setup-sam@v2 | ||
with: | ||
version: 1.49.0 | ||
- name: Install SAM example packages | ||
# Since we are not managing the SAM examples with npm workspaces we install | ||
# the dependencies in a separate step | ||
|
@@ -43,16 +47,15 @@ jobs: | |
contents: read | ||
strategy: | ||
matrix: | ||
version: [12, 14] | ||
package: [logger, metrics, tracer] | ||
version: [12, 14, 16] | ||
steps: | ||
- name: "Checkout" | ||
uses: actions/checkout@v3 | ||
- name: "Use NodeJS 14" | ||
- name: "Use NodeJS 16" | ||
uses: actions/setup-node@v3 | ||
with: | ||
# Always use version 14 as we use TypeScript target es2020 | ||
node-version: 14 | ||
node-version: 16 | ||
- name: "Install [email protected]" | ||
run: npm i -g npm@next-8 | ||
- name: "Install monorepo packages" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,7 @@ The alternative is to use a Cloud IDE like [Gitpod](https://www.gitpod.io/) or [ | |
|
||
The following tools need to be installed on your system prior to starting working on a pull request: | ||
|
||
- [Node.js >= 14.18.1](https://nodejs.org/download/release/latest-v14.x/) | ||
- [Node.js >= 16.x](https://nodejs.org/download/release/latest-v16.x/) | ||
- We recommend using a version in [Active LTS](https://nodejs.org/en/about/releases/) | ||
- If you use [nvm](https://github.com/nvm-sh/nvm#nvmrc) or [fnm](https://github.com/Schniz/fnm) you can install the latest LTS version with `nvm use` or `fnm use` respectively. Both will use the `.nvmrc` file in the project's root. | ||
- [npm 8.x](https://www.npmjs.com/) | ||
|
@@ -250,7 +250,7 @@ Contributions via pull requests are much appreciated. | |
|
||
### Summary | ||
|
||
* This project uses `node@14.x` and `[email protected]` for development (see [Setup](#setup)). | ||
* This project uses `node@16.x` and `[email protected]` for development (see [Setup](#setup)). | ||
* Before opening a Pull Request, please find the existing related issue or open a new one to discuss the proposed changes. A PR without a related issue or discussion has a high risk of being rejected. We are very appreciative and thankful for your time and efforts, and we want to make sure they are not wasted. | ||
* After your proposal has been reviewed and accepted by at least one of the project's maintainers, you can submit a pull request. | ||
* When opening a PR, make sure to follow the checklist inside the pull request template. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,9 +83,9 @@ | |
"lib/**/*" | ||
], | ||
"engines": { | ||
"node": ">=10" | ||
"node": ">=12" | ||
}, | ||
"dependencies": { | ||
"hosted-git-info": "^5.0.0" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Is this intentional or just for debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I need to remove this