-
Notifications
You must be signed in to change notification settings - Fork 154
Add class documentation FunctionSegmentNotDefinedErrorunexpected and make end_time optional #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
~@ijemmy I'm merging a bunch of dependabot PRs that came up after we merged the last PR. After I'm done ( EDIT: not needed, discard this message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these, minor improvements but happy to merge it as it is
@@ -1,3 +1,10 @@ | |||
/** | |||
* Thrown when the function segement (AWS::Lambda::Function) is not found in a trace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
* Thrown when the function segement (AWS::Lambda::Function) is not found in a trace. | |
* Thrown when the function segment (AWS::Lambda::Function) is not found in a trace. |
/** | ||
* Thrown when the function segement (AWS::Lambda::Function) is not found in a trace. | ||
* | ||
* X-Ray segments are process asynchronously. They may not be available even after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* X-Ray segments are process asynchronously. They may not be available even after | |
* X-Ray segments are processed asynchronously. They may not be available even after |
Description of your changes
Fix @saragerion 's comments on PR #828
end_time
optional as it can be undefined sometimes.How to verify this change
Run E2E test
Related issues, RFCs
N/A
PR status
Is this ready for review?: Yes
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.