Skip to content

docs(all): add toc to README.md and CONTRIBUTING.md #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 17, 2022
Merged

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Mar 3, 2022

Description of your changes

Add table of contents to CONTRIBUTING.md and README.md

Both files are large and hard to navigate. Adding ToC will help readers to see the over all structure and can navigate to the relevant content quicker.

How to verify this change

Preview the Markdown File and click on the links in ToC.

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy requested review from dreamorosi and saragerion March 3, 2022 15:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 3, 2022
dreamorosi
dreamorosi previously approved these changes Mar 3, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@orozcoadrian
Copy link

Reminder that github has a built-in (and automatically-generated/always up-to-date) ToC ux feature.

Having multiple ways to navigate is probably ok, we'll just need to remember to check if the ToC needs updating whenever content in the page changes.

image

Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I think this will definitely improve the docs experience. I added some minor suggestions :)

@saragerion
Copy link
Contributor

@orozcoadrian thanks for bringing this up. Indeed you are right. In my opinion, The downside of the Github ToC is:

  • 1 click necessary
  • hard to scroll and read the long list of headings

Hence the need for this more manual approach.

@dreamorosi
Copy link
Contributor

+1 on having an explicit in-text ToC.

I use GitHub on mobile more than half of the time and it doesn't support the feature yet :(

Downside of this is that we'll have to remember to keep it updated, but hopefully these docs won't be changing all the time.

Co-authored-by: Sara Gerion <[email protected]>
ijemmy and others added 4 commits March 17, 2022 11:23
@dreamorosi dreamorosi self-requested a review March 17, 2022 10:36
@ijemmy ijemmy merged commit c5e7dce into main Mar 17, 2022
@ijemmy ijemmy deleted the ijemmy/add-toc branch March 17, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants