-
Notifications
You must be signed in to change notification settings - Fork 154
docs(all): add toc to README.md and CONTRIBUTING.md #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
…ng PR + Limit toc to 3 levels instead of 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I think this will definitely improve the docs experience. I added some minor suggestions :)
@orozcoadrian thanks for bringing this up. Indeed you are right. In my opinion, The downside of the Github ToC is:
Hence the need for this more manual approach. |
+1 on having an explicit in-text ToC. I use GitHub on mobile more than half of the time and it doesn't support the feature yet :( Downside of this is that we'll have to remember to keep it updated, but hopefully these docs won't be changing all the time. |
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Description of your changes
Add table of contents to CONTRIBUTING.md and README.md
Both files are large and hard to navigate. Adding ToC will help readers to see the over all structure and can navigate to the relevant content quicker.
How to verify this change
Preview the Markdown File and click on the links in ToC.
Related issues, RFCs
N/A
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.