chore(all): Switch to use only eu-west-1 in tests and doc #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid confusion as E2E now runs in both region (logger use eu-central-1 while others use eu-west-1). It will throw an error if contributors did not cdk bootstrap both region properly. In addition, the `tests/resources/contexts/hello-world.ts` file is shared among utilities so we should keep the region consistent
github-actions
bot
added
the
internal
flochaz
approved these changes
Feb 17, 2022
dreamorosi
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Make all region reference to eu-west-1 instead of eu-central-1
This is to avoid confusion as
eu-central-1). Also, fetching the log/metrics/grace with AWS SDK has to be from the same region.tests/resources/contexts/hello-world.tsfile is shared among utilities. The file specifyeu-central-1but we actually useeu-west-1in some tests. It is not clear (unless tracing the code) on which region the test is using.With this case, everything is on
eu-west-1, including examples and documentation.How to verify this change
Run both unit and e2e tests
Related issues, RFCs
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.