docs: Tracer example link goes to a 404 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update tracer link to go to https://github.com/awslabs/aws-lambda-powertools-typescript/tree/main/examples/cdk/lib
github-actions
bot
added
the
documentation
dreamorosi
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Thanks a lot for the PR!
I left a couple of comments, one is just a note while the other is a change.
After addressing them, could you please update also the README.md files in each package?
- https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/commons/README.md
- https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/metrics/README.md
- https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/logger/README.md
- https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/tracing/README.md
This repo uses a monorepo structure and all packages are published on NPM separately so we need a README file in each one.
|
@dreamorosi - i have updated the changes. FYI i am using markdownlint for editing and validating the MD files. |
|
@dreamorosi should all be resolved now |
ijemmy
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
LGTM + installed markdownlint :) Thanks for the recommendation @michaelbrewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Changes:
https://github.com/awslabs/aws-lambda-powertools-typescript/tree/main/examples/cdk/libHow to verify this change
Build and run the docs and click on the changed links.
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.