Skip to content

chore(event-handler): align implementation with other runtimes #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 28, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR makes a few targeted changes to the implementation of the BedrockAgentFunctionResolver upcoming feature, specifically:

  • removed 5 tools limit on the grounds that customers can create multiple action groups in their agents backed by the same Lambda function, and thus there's no point in restricting the numbers of tools - we'll however call out the 5 tools limit in the docs (separate PR)
  • made sure session, prompt, and knowledge base configurations are always propagated in responses
  • removed decorator implementation because of the unsolved bug described in Bug: AppSyncEventsResolver decorators break scope #3973
  • added a new BedrockFunctionResponse class that is both used under the hood by the resolver class to build responses and can be used by customers to fully customize the response with things like session attributes of statuses
  • added docstring comments to all types, classes, and methods & added the submodule to API docs reference

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3988


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this May 28, 2025
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels May 28, 2025
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label May 28, 2025
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@dreamorosi dreamorosi merged commit 81733be into main May 28, 2025
41 checks passed
@dreamorosi dreamorosi deleted the chore/align_implementation branch May 28, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-handler This item relates to the Event Handler Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: align implementation of Bedrock Agent Function resolver
2 participants