fix(parameters): preserve original stack trace on transform failures … #3982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
parameters
|
Thank you @VatsalGoel3 for the PR and for fixing the issue! @leandrodamascena, I made a commit to fix test coverage and I'd appreciate a review - the change is minimal and it'd be ok to merge from my side. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(parameters): preserve original stack trace on transform failures #3950
Summary
We were previously wrapping a thrown
TransformParameterErrorinside a new instance, which stripped out the original stack trace pointing totransformValue.js. This PR makes sure that:TransformParameterErroris thrown, we rethrow it directly.TransformParameterError, we copy over the originalerror.stackso that users see the exact call site of the failure.Changes
for (… transformValue…)loop’scatchblock:TransformParameterErrorinstances without wrapping.wrapped.stack = error.stackbefore throwing.Issue number: closes #3950
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.