Skip to content

feat(ALL): Use optional callback LambdaInterface for decorator #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 4, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 4, 2022

Description of your changes

Use newly released LambdaInterface which enable handler to be either Sync with callback or ASync without callback

How to verify this change

npm run lerna-ci
npm run lerna-test

Related issues, RFCs

#396

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@flochaz flochaz changed the title feat(metrics): Use optional callback LambdaInterface for decorator feat(ALL): Use optional callback LambdaInterface for decorator Jan 4, 2022
ijemmy
ijemmy previously approved these changes Jan 4, 2022
saragerion
saragerion previously approved these changes Jan 4, 2022
@dreamorosi dreamorosi dismissed stale reviews from saragerion and ijemmy via 8cfb7ea January 4, 2022 17:45
@dreamorosi dreamorosi added this to the beta-release milestone Jan 4, 2022
@dreamorosi dreamorosi added all dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Jan 4, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dreamorosi dreamorosi linked an issue Jan 4, 2022 that may be closed by this pull request
@flochaz flochaz merged commit 6413215 into main Jan 4, 2022
@flochaz flochaz deleted the feat/metrics/callBackOptional branch January 4, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Movel all modules to use this new LambdaInterface
4 participants