-
Notifications
You must be signed in to change notification settings - Fork 156
fix(metrics): addDimensions() documentation and tests #3964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(metrics): addDimensions() documentation and tests #3964
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for catching this! I've reverted the types/index.ts file to its original state. This was an unintended change that happened during the implementation. The PR now only contains documentation updates and test fixes. |
Hi @matteofigus, I'll pick up the review for this right after the release of Bedrock Agent Functions on Tue 06/03. |
8f8454b
to
6278aa8
Compare
|
Fix:
addDimensions()
should create a setSummary
Changes
This PR fixes issue #3777 where
addDimensions()
was incorrectly adding dimensions to the existing set instead of creating a new dimension set.Changes made:
addDimensions()
method inMetrics.ts
to create a new dimension set rather than adding to existing dimensionsdimensionSets
array to store multiple dimension setsaddDimensions()
Documentation updates:
addDimensions()
to create multiple dimension setsaddDimensions()
creates a new set rather than modifying existing dimensionsIssue number: #3777
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.