Skip to content

feat(commons): update types to have optional callback #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 3, 2022

Description of your changes

Following discussions made here: DefinitelyTyped/DefinitelyTyped#38342 (comment) and the proposed solution made here: https://www.npmjs.com/package/aws-lambda-consumer , this PR enable to specify lambda handlers with or without callback depending on if it's a sync or async call.

How to verify this change

cd packages/commons
npm run test

Also tested against Metrics decorator . PR will follw

Related issues, RFCs

#381

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added this to the beta-release milestone Jan 3, 2022
@dreamorosi dreamorosi linked an issue Jan 3, 2022 that may be closed by this pull request
@flochaz flochaz force-pushed the fix/all/handlerType branch from 80e891b to 3179b5c Compare January 4, 2022 06:36
@flochaz flochaz force-pushed the fix/all/handlerType branch from 3179b5c to ac53385 Compare January 4, 2022 06:38
@flochaz flochaz merged commit 45edbac into main Jan 4, 2022
@flochaz flochaz deleted the fix/all/handlerType branch January 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Make all elements optionals in Lambda Handler type
3 participants